Repository navigation
refactor(agc): name dbOlWdppb4o and vieBRwlh1Lw the _10000 interpolant mappings - #5848
Merged
adriadam10 merged 1 commit intoOct 15, 2026
Conversation
…t mappings The names hash to the NIDs dbOlWdppb4o and vieBRwlh1Lw that the exports carried as sceAgcUnknownCreateInterpolantMapping and sceAgcUnknown_vieBRwlh1Lw. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Progress report (caee23f → a0fc988)➖ System libraries: 88.34% (+0.0%, +2 implemented, -2 removed functions) ✅ 2 implemented
🗑️ 2 removed
|
This was referenced Oct 14, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
Collaborator
|
Checked that |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Names the two libSceAgc stubs that were exported only by NID. The names hash to those NIDs with
tools/nid_names.py:They are the next versions of the existing
sceAgcCreateInterpolantMapping_0100/sceAgcUpdateInterpolantMapping_0100pair (HV4j+E0MBHE,k0E7vkgqAuE), with a five-digit version suffix; neither name is in the aerolib NID list. As in #2319, the functions inShader/src/InterpolantMapping.cppare renamed and theirAPS5_EXPORTaliases dropped, so the NID patcher derives the same NIDs from the names. The behaviour is unchanged;tests/InterpolantMapping.cppand the threedocs/dev/debt/libSceAgc.mdentries use the new names.Partly addresses #2355:
dbOlWdppb4ois called from nine sites in PPSA26344 (call-site evidence there);vieBRwlh1Lwis imported by PPSA12544 (#699, #3829).Tested
Windows 11 26200, WinLibs GCC 15.2.0 UCRT, full build with
BUILD_TESTING=ONonmain5a6ad0ed3(rebased since ontocaee23fd9; the touched files did not change).libSceAgc.prxbefore and after:dbOlWdppb4oandvieBRwlh1Lware exported in both; the unpatched library now names themsceAgcCreateInterpolantMapping_10000/sceAgcUpdateInterpolantMapping_10000, and the stray name-hash exports of the old placeholder names (JmwlWB9ikTs,iN76DQZU8TE) are gone.agc_interpolant_mapping(CPU-only register test) andpatched_librariespass.python tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code